Chromium Main Console
Legend: | Passed | Failed | Running | Exception |
pine: Add onboarding illustration
This adds the pine onboarding dialog illustration and modifies Ash to
support Skottie animations with the image data embedded directly in
the lottie file.
Illustrations: https://screenshot.googleplex.com/BYbqKeiKo8bRcro
https://screenshot.googleplex.com/5ozg2GeZfYZzGZP
Dependent on https://skia-review.googlesource.com/c/skia/+/833441.
Bug: b/326434696
Change-Id: I98036c5e4a28047d116f72202cbeb1c9d33b4ddd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5368879
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Sophie Wen <sophiewen@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1280043}
Roll ANGLE from b4cf07c365c8 to 2b66694d37de (6 revisions)
https://chromium.googlesource.com/angle/angle.git/+log/b4cf07c365c8..2b66694d37de
2024-03-28 lexa.knyazev@gmail.com Metal: Untangle public draw calls
2024-03-28 yuxinhu@google.com Remove test suppression of dEQP-EGL*robustness on Pixel 6
2024-03-28 syoussefi@chromium.org Vulkan: Allow depth and stencil resolve to be separately added
2024-03-28 syoussefi@chromium.org Add a few use-after-resolve depth/stencil framebuffer tests
2024-03-28 syoussefi@chromium.org Translator: Disallow samplers in structs in interface blocks
2024-03-28 angle-autoroll@skia-public.iam.gserviceaccount.com Manual roll SwiftShader from 0bacc751b4d1 to 6912e7d5b75a (2 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Bug: chromium:328859176
Tbr: solti@google.com
Change-Id: I4100de576e482d52d27c3adea619c5add294c554
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5405510
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1280042}
Roll Chrome Lacros Amd64 Generic PGO Profile
Roll Chrome Lacros Amd64 PGO profile from chrome-chromeos-amd64-generic-main-1711627678-734b6b6ea15a46d657235524c25ec87d882b2c5d-5a4f4fb43d7597f178d453c003d869fc34c59bff.profdata to chrome-chromeos-amd64-generic-main-1711670326-e42a8d296e3c18686f794ee0888c0527ba0e2eba-0640644b7f2820b83d682e7f7e5acf6551992ad5.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-lacros-amd64-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: pgo-profile-sheriffs@google.com
Change-Id: I4ee8eeeabcce08ede794fe949e3283161c054a9f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5406206
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1280041}
WebNN: Define DirectML Node for gru MLOperator
This CL implements gru operator for DirectML backend and adds a unit
test `WebNNGraphImplBackendTest.BuildAndComputeSingleOperatorGru`.
Bug: 40206287
Change-Id: I5f859f7bdfabd8cb7c07f8da2b3c415907a9906f
Cq-Include-Trybots: luci.chromium.try:gpu-fyi-try-win11-qualcomm-rel-64,win11-blink-rel
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5339174
Reviewed-by: Rafael Cintron <rafael.cintron@microsoft.com>
Reviewed-by: ningxin hu <ningxin.hu@intel.com>
Commit-Queue: Bin Miao <bin.miao@intel.com>
Cr-Commit-Position: refs/heads/main@{#1280040}
Remove DanglingUntriaged annotation from BrotliSourceStream.
It uses a raw_ptr to store a pointer to library-managed memory. Just
have to clear the pointer prior to calling the library's cleanup
function, rather than before.
Bug: 40212619
Change-Id: If87a57a24b07e9a18bb61e8f2d9dfedab10d862f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5405634
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Commit-Queue: mmenke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1280039}
Roll src/chrome/browser/resources/preinstalled_web_apps/internal/ 23b508af8..674dff74c (1 commit)
https://chrome-internal.googlesource.com/chrome/components/default_apps.git/+log/23b508af8856..674dff74ca60
$ git log 23b508af8..674dff74c --date=short --no-merges --format='%ad %ae %s'
2024-03-28 dmblack Provide icon and title in container app preinstallation config.
Created with:
roll-dep src/chrome/browser/resources/preinstalled_web_apps/internal
Bug: b:329710379, b:329710856
Change-Id: I44db9a58318177ad14c139090fee474225c3c481
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5406365
Commit-Queue: David Black <dmblack@google.com>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1280038}
Expand tailored warnings to downloads page
Previously tailored warnings (cookie theft and suspicious archive)
are only shown on download bubble. This CL expands them to downloads
page.
Screenshots: https://drive.google.com/drive/folders/1pzEgNMJFPKdPf78PAXZTQwoRrrV5-Sue?usp=sharing
Bug: 329325809
Change-Id: I7aa2edb8c9f50abae1bb2bf4055658c29d234cbd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5366565
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Xinghui Lu <xinghuilu@chromium.org>
Reviewed-by: Alex Gough <ajgo@chromium.org>
Reviewed-by: Lily Chen <chlily@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1280037}
Roll optimization-guide from ab04e9f8dc14 to 9e938bc0da51
https://chrome-internal.googlesource.com/chrome/components/optimization_guide.git/+log/ab04e9f8dc14..9e938bc0da51
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/optimization-guide-chromium
Please CC chrome-intelligence-core@google.com,sophiechang@chromium.org on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: chromium:331206364
Change-Id: I53d992568569a2bcd37291899e7a4ba0fa73190b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5406594
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1280036}
Add checks to avoid null pointer exceptions when checking viewport-fit
Bug: 329990047
Change-Id: If0d3110ce8bb049e50a7a2ad1e434a31557eb8f2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5399127
Reviewed-by: Theresa Sullivan <twellington@chromium.org>
Commit-Queue: Charles Hager <clhager@google.com>
Reviewed-by: Charlie Reis <creis@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1280035}
Roll clank/internal/apps from c2b090fb3726 to d0ba592ded6d (1 revision)
https://chrome-internal.googlesource.com/clank/internal/apps.git/+log/c2b090fb3726..d0ba592ded6d
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/clank-apps-chromium-autoroll
Please CC chrome-brapp-engprod@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr:
No-Try: true
Change-Id: I66c10f91a2449e0f096068c90cdd5d4f7986d4f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5406596
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1280034}
Remove unused includes of threading_primitives.h
threading_primitives.h just contains RecursiveMutex now, which we are
trying to deprecate and remove. In preparation for this, remove unused
includes of this header file.
Presubmit checks also flagged two includes of <memory> so remove
those too.
Bug: 856641
Change-Id: Ie5f4cf5e94485c98aec0e469b1cd37d9bb5daa9d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5405863
Commit-Queue: Michael Wilson <mjwilson@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1280033}
Roll Chrome Win ARM64 PGO Profile
Roll Chrome Win ARM64 PGO profile from chrome-win-arm64-main-1711648703-c69c8ac844baa86f665bf032e01087f01633dd34-3b3281dcc639b9456542fd254efb2b6f832fd11b.profdata to chrome-win-arm64-main-1711670326-98736e550a98fcc7ef37f1fa502b7018aab4241f-0640644b7f2820b83d682e7f7e5acf6551992ad5.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win-arm64-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: pgo-profile-sheriffs@google.com
Change-Id: I54b173e590ca449dfe7b1a8fcd764c01f38d0f05
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5406203
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1280032}
[UIA] Fix live regions on Views when UIA is enabled
Enabling UIA in Chromium led NVDA to stop announcing some live region
events when fired from Views. Narrator was also unable to announce them.
This was caused by a bug in the new-ish announcement mechanism
introduced in CL:4986151. While this change is a net improvement to the
accessibility platform for Views, on UIA, the live regions were being
fired by a node that was not exposed in the UIA control tree. The
control tree is what ATs look at to find where the live region event is
coming from, so it's crucial that all nodes firing live regions are
part of that tree.
This CL fixes this issue, and adds a test to prevent future regressions.
Fixed: 330806089
Change-Id: I9a2d83e80d4078ec45872f3cd90176723a5865e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5404780
Reviewed-by: Jacques Newman <janewman@microsoft.com>
Commit-Queue: Benjamin Beaudry <benjamin.beaudry@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1280031}
Specify illustration colors as Ash only
Illustration colors are currently only used in Ash. The mixer for these
colors is ash/style/ash_color_mixer.cc. Specify that
native_color_mixer_chromeos is primarily for colors shared between Ash
and Lacros.
Bug: b:324657627
Change-Id: Ie40d6c8e660ad413865e1e71e96abf5b6d59eb5d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5376753
Reviewed-by: Thomas Lukaszewicz <tluk@chromium.org>
Commit-Queue: Sean Kau <skau@chromium.org>
Auto-Submit: Sean Kau <skau@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1280030}
Migrate toolbar test to Mocha+TS and add other test coverage for the
webui toolbar flag
Bug: 323960128
Change-Id: I12050a87c3cada676bd3e3a33d133c163b0845f2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5367536
Commit-Queue: Kristi Saney <kristislee@google.com>
Reviewed-by: Lauren Winston <lwinston@google.com>
Cr-Commit-Position: refs/heads/main@{#1280029}
EarlyHints: notify early hints hit to devtools
The CL notifies whether a resource load hits the early hints in the
responseReceived event. The corresponding resources will
show 'early-hints' as their initiator type.
Bug: 40222701
Change-Id: Ifc4a113489c83e639d58353d0084a21b56733ab6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5348938
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Commit-Queue: Jiacheng Guo <gjc@google.com>
Cr-Commit-Position: refs/heads/main@{#1280028}
Fix Check for AAC on Windows N
In the context of Windows N SKU, the isTypeSupported function
does not include support for AAC (Advanced Audio Coding) encoding.
In standard Windows operating systems, AAC encoding relies on the
Media Foundation library. However, this library is not installed
by default in Windows N SKU, resulting in the lack of AAC encoding support.
The straightforward solution is to check whether the system is
running Windows N SKU and return false for AAC support.
An alternative approach involves examining the presence of
the Media Foundation binaries (such as mf.dll). Unfortunately,
this file existence check cannot be performed directly in the
renderer process. The GPU process already handles this check,
but the isTypeSupported API operates synchronously and cannot
utilize a Mojo-based solution.
It’s worth noting that Windows N SKU is optional for European
countries and Korea, although it is not widely used. Therefore,
a simple check based on the product type could be a more effective solution.
Bug: 329698355
Change-Id: I00e946895d18377e87c6b8c57539184722c086f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5379757
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Sunggook Chue <sunggch@microsoft.com>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Markus Handell <handellm@google.com>
Cr-Commit-Position: refs/heads/main@{#1280027}
Roll Chrome Android ARM32 PGO Profile
Roll Chrome Android ARM32 PGO profile from chrome-android32-main-1711648703-c6fa5df21ab1cdaabd05451767bb7bd8ed5ca2bf-3b3281dcc639b9456542fd254efb2b6f832fd11b.profdata to chrome-android32-main-1711670326-bebaacd3f5509b9e9cab3099f8663f148bafeb67-0640644b7f2820b83d682e7f7e5acf6551992ad5.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-android-arm32-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: pgo-profile-sheriffs@google.com
Change-Id: I5119339211806c4a4b5eb6e9b39ff8d528ecc36f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5406593
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1280026}
Reland "Implement h.265 parameter sets tracker."
This is a reland of commit b301f592993e928be89a363aa729c952a1274757
Compared with the original CL, this reland creates
H265ParameterSetsTracker for H.265 only.
Original change's description:
> Implement h.265 parameter sets tracker.
>
> RTP spec for H.265 requires parameter sets to be included in IRAP
> pictures. This CL adds the helper for rtc_video_encoder to deliver
> encoded bitstream for all VEA outputs.
>
> This CL is based on Jianlin's CL https://crrev.com/c/5307256.
>
> Co-authored-by: Jianlin Qiu <jianlin.qiu@intel.com>
>
> Bug: webrtc:13485
> Change-Id: I6cfba23c957fdc90deb66b7e580c8a20cd22aef3
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5335904
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Dan Sanders <sandersd@chromium.org>
> Commit-Queue: Jianlin Qiu <jianlin.qiu@intel.com>
> Cr-Commit-Position: refs/heads/main@{#1277264}
Bug: webrtc:13485
Change-Id: I8ec1a20e25b35d1b899b4f4b1d7448894b08a487
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5396998
Reviewed-by: Erik Språng <sprang@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Jianjun Zhu <jianjun.zhu@intel.com>
Reviewed-by: Sergey Silkin <ssilkin@chromium.org>
Reviewed-by: Jianlin Qiu <jianlin.qiu@intel.com>
Cr-Commit-Position: refs/heads/main@{#1280025}
Roll Perfetto Trace Processor Win from 23175f5af147 to dc303d1163c1
https://android.googlesource.com/platform/external/perfetto.git/+log/23175f5af147..dc303d1163c1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium
Please CC chrometto-team@google.com,perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: perfetto-bugs@google.com
Change-Id: Id42d0206eecdae46204ac2dc6d33b591de443929
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5405870
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1280024}
Revert "Update espresso to 3.5.1"
This reverts commit a493814d8f5741ecbf1508692cb0078d34f22605.
Reason for revert:
androidx_fetchall.py seems to be giving an error:
java.lang.AssertionError: No dependency collected for artifact checker-compat-qual. Expression: dep. Values: dep = null
I suspect that will cause
https://skia-autoroll.corp.goog/r/google3-libs-clank-internal-apps
to fail on its next roll.
Original change's description:
> Update espresso to 3.5.1
>
> Should update code to {{androidx_dependency_version}} after this lands successfully.
>
>
> Change-Id: I84113ee44f91127e45db3617951913128a2dd55a
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5405915
> Reviewed-by: Peter Wen <wnwen@chromium.org>
> Reviewed-by: Andrew Grieve <agrieve@chromium.org>
> Commit-Queue: Andrew Grieve <agrieve@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1279851}
Change-Id: I2122998e710d955dded34c38a105ab451b8c144f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5406062
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1280023}
[ios] Remove field trial config for user policy
Change-Id: I192bad75ca5a9d91fbdd7ddc63186d52243f3ea1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5403608
Commit-Queue: Vincent Boisselle <vincb@google.com>
Reviewed-by: Victor Vianna <victorvianna@google.com>
Cr-Commit-Position: refs/heads/main@{#1280022}
Make ChildProcessSecurityPolicy::CanCommitURL content-internal.
Code outside //content shouldn't really be asking whether a particular
URL is allowed to commit in a given process, since the actual
navigation commit logic is inside //content. CanCommitURL() was
already not used by non-test code outside of //content, so this CL
moves it out of the content/public ChildProcessSecurityPolicy API. It
remains accessible via ChildProcessSecurityPolicyImpl, and a test-only
helper is added to maintain coverage in an extension-related
blob/filesystem test.
Bug: 325410297
Change-Id: I158786a41a26e88c506b0c0543fd6760387111c2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5398459
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Commit-Queue: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1280021}
gardener: disable DelayloadsTest.ChromeDllDelayloadsCheck on Win
Bug: 331859923
Change-Id: I32befc147b451c1dbb08b15ca55d19ffde5f7592
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5404437
Reviewed-by: Taiyo Mizuhashi <taiyo@chromium.org>
Commit-Queue: Huanpo Lin <robertlin@chromium.org>
Owners-Override: Robert Lin <robertlin@google.com>
Cr-Commit-Position: refs/heads/main@{#1280020}
updater: add a `lang` parameter to the app logo url
This can allow for an app to serve a localized logo with eventual server
side support. The URL is now of the form:
https://dl.google.com/update2/installers/icons/appid.bmp?lang=en
This URL currently serves `appid.bmp` statically, but can serve a
localized bmp in the future.
Bug: 325372957
Change-Id: I1b9873a3cec084dae18eb584d5f0d61ae090b953
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5406244
Commit-Queue: Xiaoling Bao <xiaolingbao@chromium.org>
Reviewed-by: Xiaoling Bao <xiaolingbao@chromium.org>
Auto-Submit: S Ganesh <ganesh@chromium.org>
Commit-Queue: S Ganesh <ganesh@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1280019}
Roll Chrome Mac Arm PGO Profile
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-main-1711662447-3ef4d6dfa5708ab2f703424591dbb96dcbd271f4-13dc9eae05d2638c112ff003c9b200824c990542.profdata to chrome-mac-arm-main-1711670326-a01e0fa97da7b7881775144495106de4afbd40dc-0640644b7f2820b83d682e7f7e5acf6551992ad5.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-arm-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: I19fc660b1ca92a38dbe40e7692ce800bb28e4e75
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5406326
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1280018}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-main-1711637935-33bef6576464abd0318d44b923d459563d4eb4a6-3b0e5fc5913d30337201838876b5a4832dac8f58.profdata to chrome-win32-main-1711648703-554273f73a3077bbef6a93e714f56c03a874177b-3b3281dcc639b9456542fd254efb2b6f832fd11b.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: I18414bf0b2ac7c95ab6f6352a245c9bcceb39fa8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5405081
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1280017}
[SAA] Use async functions in wpts where possible
It's still easier to keep the top level as an async_test (which cannot
be async), but the inner functions can be async as needed.
Bug: 40282415
Change-Id: I6001912cf2510e140f7980154e24705a30088cc4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5402469
Reviewed-by: Dylan Cutler <dylancutler@google.com>
Commit-Queue: Ari Chivukula <arichiv@chromium.org>
Auto-Submit: Ari Chivukula <arichiv@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1280016}
webnn: Remove redundant arguments in CoreML graph builder
Also cleans up some data types and reformats the affected files
Change-Id: I427a608dbfa5c73d482f9bb8676eba21fdcb5aea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5405394
Auto-Submit: Austin Sullivan <asully@chromium.org>
Reviewed-by: Phillis Tang <phillis@chromium.org>
Commit-Queue: Austin Sullivan <asully@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1280015}
Directly update tucked floated bounds when rotated
This CL changes FloatController to directly set bounds for tucked ARC++
windows on rotation.
When a floated window is tucked, ash has the control over the bounds
despite the client-controlled model.
Therefore, we should update the bounds directly, otherwise ARC++ may not
set the proper bounds.
BUG=b:331706252
TEST=TuckAndUntuckFloatedWindowInTabletMode
Change-Id: I97c41b6afdfe06b57cec31b691bccb01a4c99a57
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5403772
Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Commit-Queue: Toshiki Kikuchi <toshikikikuchi@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1280014}
Add CDP commands for manipulating Device Posture without other device overrides
Relying on SetDeviceMetricsOverride() does not work in WebDriver for a
number of reasons:
1. Some parameters are mandatory, but there is
"GetDeviceMetricsOverride()", and even though we can infer some
values for the parameters from other sources, actually setting them
to non-zero values in SetDeviceMetricsOverride() causes them to be
fixed to those values until ClearDeviceMetricsOverride() is called.
2. Not setting optional parameters also has effects, as it causes some
default overrides to be set, and also remain with the same values
until another call to SetDeviceMetricsOverride() or until
ClearDeviceMetricsOverride() is called.
3. Having one call that changes multiple aspects does not work well if
we just want to set a Device Posture override. It will reset any
viewport segment overrides, and vice-versa, for example.
We could fix 2) and 3) by exposing some getters for the current values
and not doing anything if we're setting them to the same ones, but 1) is
harder to solve because the current semantics and syntax are stable in
CDP.
For now, the easiest approach is to expose new CDP commands that only
manipulate Device Posture overrides. The existing Device Posture code in
the SetDeviceMetricsOverride() implementation in Blink simply calls the
same override-related commands in DevicePostureProviderImpl via Mojo, so
the behavior in these commands is essentially identical.
The tests were copied from http/tests/inspector-protocol/device-posture
and slightly adapted to also include clearDevicePostureOverride().
Bug: 330376761
Change-Id: I3285ae8fc56c068653ae9136c1a16131a96ce754
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5401658
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Raphael Kubo Da Costa <raphael.kubo.da.costa@intel.com>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Alexis Menard <alexis.menard@intel.com>
Cr-Commit-Position: refs/heads/main@{#1280013}
Roll Perfetto Trace Processor Linux from 23175f5af147 to dc303d1163c1
https://android.googlesource.com/platform/external/perfetto.git/+log/23175f5af147..dc303d1163c1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium
Please CC chrometto-team@google.com,perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: perfetto-bugs@google.com
Change-Id: I493baa465ede46759bab25dfca23f279a5be9f2e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5406080
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1280012}
Use base::HeapArray in PreReadFileSlow.
Bug: 326457874
Change-Id: Iab79c7b50f51fdeb834711309cc5661cbd9292ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5405717
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1280011}
Printing: Create launch Printer Settings from Preview test
This test:
- Opens print preview in a browser
- Navigates to an empty destination dialog
- Clicks Manage Printers to open printer settings
For ease of testing I added a view identifier to represent all
Constrained Web Dialog. It currently only has 3 consumers
(print preview, email confirmation dialog, and certificate viewer) so
this should be satisfactory from a testing perspective.
Bug: b/307385730, b/330714117
Change-Id: I533341cfcf732c2941b15334315c523338c1c1af
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5380000
Reviewed-by: Dana Fried <dfried@chromium.org>
Reviewed-by: Michael Checo <michaelcheco@google.com>
Commit-Queue: Gavin Williams <gavinwill@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1280010}
Roll Website from 5ba83b44da03 to 4da278351a31 (6 revisions)
https://chromium.googlesource.com/website.git/+log/5ba83b44da03..4da278351a31
2024-03-28 jhawkins@chromium.org CrOS Developer Library: Move more device docs.
2024-03-28 jingmuli@google.com CrOS Developer Library: Move pages to guides
2024-03-28 cambickel@google.com cros-dev-library: Move three portage pages
2024-03-28 jyasskin@google.com Ask for a month of vendor review.
2024-03-28 hardtmad@google.com CrOS Developer Library: Move debugging how tos to guides
2024-03-28 miketaylr@chromium.org Document requirement for 3 LGTMs for longer deprecation trials
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/website-chromium
Please CC dpranke@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Website: https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: dpranke@google.com
Test: Test: none
Change-Id: I8241d316261c0c1c12cd38b753985a3aa1a13249
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5405865
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1280009}
Clean up cct-resizable-side-sheet and cct-resizable-side-sheet-for-third-parties flags
Bug: 40287277
Change-Id: Icdc71c0a4d784f4715c21e14651ceedd91d5d6a6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5403465
Reviewed-by: Kevin Grosu <kgrosu@google.com>
Commit-Queue: Zach Katz <katzz@google.com>
Cr-Commit-Position: refs/heads/main@{#1280008}
cros-preview: Add shared CSS file
- Add shared CSS file.
- Import shared CSS into polymer element styles.
- Fix unexpected scrollbar by removing margin set by
user-agent from html and body.
Bug: b:323421684
Test: Manually verified styles still applied.
Change-Id: Ie332a0e11b95f698170a6d8695f62d2d116fa9d8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5402905
Reviewed-by: Gavin Williams <gavinwill@chromium.org>
Commit-Queue: Ashley Prasad <ashleydp@google.com>
Cr-Commit-Position: refs/heads/main@{#1280007}
oak: Hide desks widgets in partial overview
Demo: http://b/330789843#comment3
Fixed: b/330789843
Test: Added new test + manually
Change-Id: Id919fc1c10672919eae4d1ee8aba2ec22c0a27a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5403681
Commit-Queue: Michele Fan <michelefan@chromium.org>
Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1280006}
Add resource for container app icon.
This will be referenced by the install config for the container app.
Bug: b:329710856
Change-Id: I8925fda0154ad06fce7bb4e111599fc9c4f44993
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5393889
Commit-Queue: David Black <dmblack@google.com>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: Alan Cutter <alancutter@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1280005}
Move Lens overlay protos to third_party/lens_server_proto
Also, changes enum value CHROMIUM because it's a compile-time keyword
Bug: b/328480001
Change-Id: I21b2898aa35c092bfe384f813ba693d6fd961a9d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5394109
Reviewed-by: Rick Byers <rbyers@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Commit-Queue: Jason Hu <hujasonx@google.com>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1280004}
Remove kill switch for checking request_file_set_ in CanRequestURL().
The features::kRequestFileSetCheckedInCanRequestURL kill switch was
introduced in https://crrev.com/c/5005884 to guard the move of
request_file_set_ checks from CanCommitURL() to CanRequestURL(). The
feature has been enabled since M121, and with stable releases already
being past that milestone, it should be safe to clean this up and
remove the old path.
Bug: 40539942
Change-Id: I194183d641a01e2c4ef8485e8ff24e5c07fd528c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5401455
Reviewed-by: Charlie Reis <creis@chromium.org>
Commit-Queue: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1280003}
Roll Catapult from e9c2ef6c9a0d to dde069cbf86f (1 revision)
https://chromium.googlesource.com/catapult.git/+log/e9c2ef6c9a0d..dde069cbf86f
2024-03-28 wnwen@chromium.org Reduce unnecessary empty log lines
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/catapult-autoroll
Please CC chrome-speed-operations@google.com,dberris@chromium.org,jbudorick@chromium.org,johnchen@chromium.org,sullivan@chromium.org,viditchitkara@google.com,wenbinzhang@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: chromium:325292888
Tbr: viditchitkara@google.com
Change-Id: I30f8b958d82969f3f923ed4831a99304d17c4f7f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5404757
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1280002}
Some mask-* property related cleanups
* Remove "Webkit" from some function names to prefer the
unprefixed names.
* Simplify SVGMaskPainter by folding PaintSVGMask(), PaintMaskLayers()
and (one instance of) ResolveElementReference().
Change-Id: Ib8283f1945fb1930d6e95b6f60c30c1276f0e948
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5401800
Auto-Submit: Fredrik Söderquist <fs@opera.com>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1280001}
Shimless: Convert fake_shimless_rma_service_test.js to ts
- Fix all ts errors and use ts styling.
- Convert tests to async.
- Remove unneeded tests that did not add value.
- Remove the special case for `chooseManuallyDisableWriteProtect()` that
made it skip ahead two states. It's easier if each page in the fake
service behaves the exact same (clicking next always moves to the next
state in the list).
Test: browser_tests --gtest_filter=ShimlessRmaApp.FakeShimlessRmaService
Bug: b:315002705
Change-Id: I11882bb9903ec67136cfefd4f95e15645444499b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5399130
Reviewed-by: Ashley Prasad <ashleydp@google.com>
Commit-Queue: Gavin Williams <gavinwill@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1280000}
Fix tryjob requirement compute failure
win-arm64-rel is under chromium/try, not chrome/try.
Change-Id: I8f3dfb6087ec137954b5162ed9645f73b6a3c76e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5406194
Auto-Submit: Alan Zhao <ayzhao@google.com>
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1279999}
webauthn: add tests for the new pop-up window UI steps.
Change-Id: I3ce5ef35fb91f1c97732f88cd1c713e014a55a17
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5386677
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Commit-Queue: Adam Langley <agl@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1279998}
Assign element IDs to infobar accept and dismiss buttons
This will make it easier to test. One of the methods was still being
used in a unit test so I left it, but I was able to remove the other.
Change-Id: I2f30144dd060a780eae919635447a44b13c3ee2b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5402436
Reviewed-by: Dana Fried <dfried@chromium.org>
Commit-Queue: Alison Gale <agale@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1279997}
Add Kurt and Ethan as Layout owners
This change adds Kurt Catti-Schmidt and Ethan Jiminez
as owners in the Layout space as experts in the Grid area.
Change-Id: Ie7cd54cf6c9609fd273393401e6df98258a01fc4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5406318
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Alison Maher <almaher@microsoft.com>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1279996}
Add a comment about Mutation Events VTS, and push out expiration
Since this virtual suite needs to stay well after the feature has
been disabled, I added a comment with the "why". This also pushes
out the expiration date to the M135 stable date.
Bug: 40268638
Change-Id: Ic537c0ae418b812338ebd7182cb08169fd823ccb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5314893
Commit-Queue: Di Zhang <dizhangg@chromium.org>
Commit-Queue: Mason Freed <masonf@chromium.org>
Auto-Submit: Mason Freed <masonf@chromium.org>
Reviewed-by: Di Zhang <dizhangg@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1279995}
Implement container-progress() function
As introduced in https://drafts.csswg.org/css-values-5/#container-progress-func
The container-progress() functional notation returns a <number> value
representing current value of the size-feature of some container, that
can be either named or unnamed, as a progress value between two explicit
calc values.
Note: for now we only support width and height features.
Note: now it's an editor's draft with a very strong chances to be accepted.
Bug: 40944203
Change-Id: I4664ad8d01174bfdc9621ca304caecc9db37c9ca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5391308
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Daniil Sakhapov <sakhapov@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1279994}